Could not find a declaration file for module 'graphql-upload'

[samalexander]

Using apollo-server-express v2.3.0 in a Typescript project produces the following error due to missing typings for the graphql-upload module.

node_modules/apollo-server-core/dist/processFileUploads.d.ts:1:49 - error TS7016: Could not find a declaration file for module 'graphql-upload'. 'node_modules/graphql-upload/lib/index.js' implicitly has an 'any' type.
  Try `npm install @types/graphql-upload` if it exists or add a new declaration (.d.ts) file containing `declare module 'graphql-upload';`

1 declare const processFileUploads: typeof import('graphql-upload').processRequest | undefined;

[simon-holm]

I have nothing helpful to add, but we have the same issue when we tried to re-deploy our server just now.

[Alexloof]

Temp solution until they have fixed it:

declare module 'graphql-upload' {
export function processRequest(
request: any,
response: any,
options?: any
): Promise
}

[onehorsetown]

Depending on your compiler settings, you might need:

declare module 'graphql-upload' {
  export function processRequest<T>(
    request: any,
    response: any,
    options?: any
  ): Promise<T>;
}

otherwise, you get this:

@types/vendor.d.ts(15,6): error TS2314: Generic type 'Promise<T>' requires 1 type argument(s)

[apoloa]

This is happening in version 2.1.0 too. And breaks all compilation in the code for this version that uses typescript. The package graphql-upload disappears from the npm.

[abernix]

Thanks for reporting this!

Please give 2.3.1 (just published) a try and see if that resolves the problem for you! This certainly supports my belief that integration tests which better test the consumption of Apollo Server would be a welcome addition to this repository.

@apoloa This particular error is certainly something new and reproducible which I wasn't seeing before. That said, sharing the specific error could be helpful because graphql-upload was not used in this project at that time (it was still apollo-upload-server, before 2.3.0.).

[samalexander]

@abernix v2.3.1 fixes the issue. Thanks!

[apoloa]

@abernix I will check which are the specific version that npm downloads.

[rebazomar121]

@onehorsetown
can you tell me where I put this code ... which setting?

[scott-lc]

@rebazomar121

https://drag13.io/posts/custom-typings/index.html
https://www.detroitlabs.com/blog/2018/02/28/adding-custom-type-definitions-to-a-third-party-library

Depending on how your code is organized, you may need to tweak your tsconfig.json typeRoots value:

https://www.typescriptlang.org/tsconfig#typeRoots