Property 'connection' does not exist on type 'ExpressContext'

[alexbjorlig]

I am trying to follow this guide, on setting up subscriptions with apollo-server-express@2.9.0, but the middleware connection check is giving a typescript problem:

Property 'connection' does not exist on type 'ExpressContext'

The code snippet:

const server = new ApolloServer({
  schema,
  context: async ({ req, connection }) => { // Typescript error here
    if (connection) {
      // check connection for metadata
      return connection.context;
    } else {
      // check from req
      const token = req.headers.authorization || "";

      return { token };
    }
  },
});

Currently, I am doing this workaround: const { req, connection } = v as any;

[abernix]

I believe this was meant to be be fixed via #2959. Is it possible you have multiple versions of apollo-server-express in your project? (You can run npm ls apollo-server-express or yarn ls apollo-server-express to find the answer).

@stefanholzapfel @Siyfion Did you find that the typing problem with the connection property was resolved after #2959?

[abernix]

@dauledk Also, whether or not it's the exact steps in the guide, including a runnable reproduction would be helpful.

[alexbjorlig]

Running npm ls apollo-server-express only gave 2.9.0. Looking around here in the github repo, are we not missing connection from this line here?

[stefanholzapfel]

@abernix @dauledk Just upgraded from 2.8.1 to 2.9.0 without any problems. Using context like this:

context: async ({ req, connection }) => {}

ExpressContext still contains the connection property:

export interface ExpressContext {
  req: express.Request;
  res: express.Response;
  connection?: ExecutionParams;
}

[alexbjorlig]

After closing VS code and opening again, the error is gone. Thanks for the help - and sorry for the inconvenience 😅

[abernix]

@dauledk No inconvenience; thanks for following up! (And thank you @stefanholzapfel for jumping in!)

[MichaelHindley]

@abernix when working with Subscriptions, you get an ExpressContext that has connection but no req or res. Shouldn't they hence be nullable?