Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade graphql-upload to 9.0 to support Node.JS 13 #3579

Closed
lcswillems opened this issue Dec 4, 2019 · 11 comments
Closed

Upgrade graphql-upload to 9.0 to support Node.JS 13 #3579

lcswillems opened this issue Dec 4, 2019 · 11 comments

Comments

@lcswillems
Copy link

Apollo Server upload feature is not working for Node.JS 13 because it uses version ^8.0.2 of graphql-upload which is not working on Node.JS 13: jaydenseric/graphql-upload#170

A new version (version 9) had been published yesterday that support Node.JS 13. Is it possible to upgrade the dependency?

@remiroyc
Copy link

remiroyc commented Dec 8, 2019

I confirm this issue. #3508

@zsolt-dev
Copy link

This should be an easy fix... Is there something that is holding back the graphql-upload upgrade to 9.0?

@mickeyschwab
Copy link

Bumping this as v10.0 has now been released. I've used resolutions to pin v10 in a project and that is what it took to resolve my upload issues.

@jz222
Copy link

jz222 commented Feb 24, 2020

Using the latest graphql-upload also doesn't work with Node 12 as outlined here jaydenseric/graphql-upload#185

@jaydenseric
Copy link

jaydenseric commented Feb 24, 2020

@jz222

Using the latest graphql-upload also doesn't work with Node 12.

That's not correct, all the tests are passing for Node.js v12:

https://github.com/jaydenseric/graphql-upload/runs/410239593?check_suite_focus=true#step:4:132

@jz222
Copy link

jz222 commented Feb 24, 2020

@jaydenseric sorry if I wasn't clear enough. I referenced the issue since you found out that it is related to mismatching versions of graphql-upload as mentioned here.

@hemedani
Copy link

please upgrade it's throwing this error : Maximum call stack size exceeded

@lucasbemol
Copy link

updates?

@hemedani
Copy link

hemedani commented Mar 3, 2020

I'm disabling upload property look at here

@abernix
Copy link
Member

abernix commented Jul 22, 2020

Duplicate of #3508. Please also see the update / suggestion I posted there in #3508 (comment)

@abernix abernix closed this as completed Jul 22, 2020
@joelmagner
Copy link

Still an issue on Node 14.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants