Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix config loading issues #1055

Merged
merged 3 commits into from
Feb 26, 2019
Merged

Fix config loading issues #1055

merged 3 commits into from
Feb 26, 2019

Conversation

JakeDawkins
Copy link
Contributor

@JakeDawkins JakeDawkins commented Feb 26, 2019 •
edited
Loading

Fixes 2 bugs:

  • VS Code not recognizing a file as being part of the project (first commit)
    • Changed it from using relative filepath (which is wrong) to use the full path as expected.
  • In monorepos, if there are multiple configs, and one fails to load, it won't load any configs.
    • Added warning for failed config including path to broken config.

screen shot 2019-02-26 at 3 09 20 pm

TODO:

  • Update CHANGELOG.md* with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.

@JakeDawkins JakeDawkins merged commit 76a8f6a into master Feb 26, 2019
@JakeDawkins JakeDawkins deleted the jake/fix-config branch February 26, 2019 21:37
trevor-scheer
trevor-scheer reviewed Feb 26, 2019
View reviewed changes
packages/apollo-language-server/src/workspace.ts
]);
})
.catch(error => console.error(error))
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spoke offline, we recognized the need to still await all the promises before calling this._onConfigFilesFound.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trevor-scheer trevor-scheer trevor-scheer left review comments

@jbaxleyiii jbaxleyiii jbaxleyiii approved these changes

Assignees
No one assigned
Labels
🐞 bug 🗒️ component - vscode related to editor tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JakeDawkins @jbaxleyiii @trevor-scheer