Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct implementation of ignore https verification #1461

Merged
merged 4 commits into from
Aug 8, 2019
Merged

correct implementation of ignore https verification #1461

merged 4 commits into from
Aug 8, 2019

Conversation

septs
Copy link
Contributor

@septs septs commented Aug 5, 2019

TODO:

  • Update CHANGELOG.md* with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.

@apollo-cla
Copy link

@septs: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@septs septs changed the title fix #928 correct implementation of ignore https verification Aug 5, 2019
@septs
Copy link
Contributor Author

septs commented Aug 6, 2019

@JakeDawkins

@trevor-scheer
Copy link
Member

Thanks so much for this PR @septs! Would you mind replicating the changes in the standard introspection provider as well?

https://github.com/apollographql/apollo-tooling/blob/1c24b14871bfa96f35c3f326a9f1022018c57468/packages/apollo-language-server/src/providers/schema/introspection.ts

@septs
Copy link
Contributor Author

septs commented Aug 7, 2019

@trevor-scheer done

@trevor-scheer trevor-scheer merged commit bb51ec7 into apollographql:master Aug 8, 2019
@trevor-scheer
Copy link
Member

Thank you 🎉

@septs
Copy link
Contributor Author

septs commented Aug 8, 2019

@trevor-scheer next release date? and closed #928 ?

@trevor-scheer
Copy link
Member

@septs will release on Monday! ~9am PST

@trevor-scheer
Copy link
Member

Released!

Successfully published:
...
 - apollo-language-server@1.14.2
 - apollo@2.17.3

@septs
Copy link
Contributor Author

septs commented Aug 13, 2019

@trevor-scheer request update vscode-apollo

@JakeDawkins
Copy link
Contributor

@septs The extension is updating right now. Should be released in a couple minutes @1.9.2. Let me know if there are any issues :)

essaji pushed a commit to essaji/apollo-tooling that referenced this pull request Aug 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants