-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin core-js version in apollo-env #961
Conversation
The API was changed in 3.0.0-beta.12. `core-js/proposals/array-flat-and-flat-map` was removed.
@bfirsh: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could fallback to one version before 12 -- 3.0.0-beta.11 in specific
We can assume that the moved dependencies will not move back, so I think it's a good idea to pin to the current latest beta, but also update the imports. Using diff --git a/node_modules/apollo-env/lib/polyfills/array.js b/node_modules/apollo-env/lib/polyfills/array.js
index 9d5bb1f..7dc6721 100644
--- a/node_modules/apollo-env/lib/polyfills/array.js
+++ b/node_modules/apollo-env/lib/polyfills/array.js
@@ -1,4 +1,5 @@
"use strict";
Object.defineProperty(exports, "__esModule", { value: true });
-require("core-js/proposals/array-flat-and-flat-map");
+require("core-js/es/array/flat");
+require("core-js/es/array/flat-map");
//# sourceMappingURL=array.js.map
diff --git a/node_modules/apollo-env/lib/polyfills/object.js b/node_modules/apollo-env/lib/polyfills/object.js
index f302992..c215afb 100644
--- a/node_modules/apollo-env/lib/polyfills/object.js
+++ b/node_modules/apollo-env/lib/polyfills/object.js
@@ -1,4 +1,4 @@
"use strict";
Object.defineProperty(exports, "__esModule", { value: true });
-require("core-js/proposals/object-from-entries");
+require("core-js/es/object/from-entries");
//# sourceMappingURL=object.js.map |
Thanks so much for this @bfirsh I'll publish this now |
Released in |
The API was changed in 3.0.0-beta.12 (released 2 hours ago) causing this error in my application:
It seems sensible to pin to a specific beta version while the API is moving around. When 3.0.0 is released, then it could be switched back to
^3.0.0
.