Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema caching broken for multiple schemas since 2.1.0 #178

Closed
1 of 5 tasks
patsissons opened this issue Oct 19, 2018 · 0 comments · Fixed by #179
Closed
1 of 5 tasks

Schema caching broken for multiple schemas since 2.1.0 #178

patsissons opened this issue Oct 19, 2018 · 0 comments · Fixed by #179
Labels
blocking Prevents production or dev due to perf, bug, build error, etc..

Comments

@patsissons
Copy link

Issue Labels

  • has-reproduction
  • feature
  • docs
  • blocking
  • good first issue

The current schema caching implementation (added in #137) currently prevents a multi-project (aka multi-schema) configuration as it keys caching on the eslint configuration, whereas schema resolution is dependent on the path to the GraphQL file being linted.

We can fix this by caching the schemas and the graphql configuration (along with the other cached elements) and instead of returning the cache entry directly, compose the cache hit into a result based on the file path being linted.

@ghost ghost added the blocking Prevents production or dev due to perf, bug, build error, etc.. label Oct 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocking Prevents production or dev due to perf, bug, build error, etc..
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant