Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to fix Koa integration tests on Node v4 #329

Closed
DxCx opened this issue Mar 20, 2017 · 8 comments
Closed

Need to fix Koa integration tests on Node v4 #329

DxCx opened this issue Mar 20, 2017 · 8 comments

Comments

@DxCx
Copy link
Contributor

DxCx commented Mar 20, 2017

KoA integration tests are broken on node 4. seems like koa uses es6 features.
we need to dig deeper to understand what was changed exactly, and make sure that the latest supported koa for node 4 i supported by us as well.

Temporary W/A which just disables Koa tests on node v4: #328

@DxCx
Copy link
Contributor Author

DxCx commented Mar 22, 2017

from koa's offical github: Koa requires node v7.6.0 or higher for ES2015 and async function support.
do we want to split packages for koa 1 & koa 2?
koa 2 removed support for node 4&6.
if not we should just disable testings for node 4&6.

@DxCx
Copy link
Contributor Author

DxCx commented Mar 22, 2017

@helfer

@soda0289
Copy link
Contributor

We could use babel with babel-register to compile the code on the fly before execution. Koa mentions this in the README:
https://github.com/koajs/koa#babel-setup

@DxCx
Copy link
Contributor Author

DxCx commented Mar 22, 2017

as much as i know apollo doesn't want to use babel,
they want the code to be supported by node 4+ as is.
we already had failing releases because testing was done using node 4 =\

@helfer
Copy link
Contributor

helfer commented Mar 24, 2017

This is indeed a little bit annoying. I think the best path forward is as @DxCx suggested: disable Koa tests on node 4 and support only Koa 2 going forward.

@DxCx
Copy link
Contributor Author

DxCx commented Mar 24, 2017

Yeah im sorry that was node 6..
You need both async and es2015

@DxCx
Copy link
Contributor Author

DxCx commented Apr 5, 2017

@helfer do we want to remove support from KOA on both Node 4 and 6 or split packages for KOA1 and KOA2?

@helfer
Copy link
Contributor

helfer commented Apr 8, 2017

@DxCx I'd be happy to remove Koa support for Node 4 and 6 going forward. I don't think it makes sense for us to put in the work if neither of us are using it. If someone who is using Koa comes forward and wants to maintain that part and make separate versions for Koa 1 and 2, we can still do that.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants