chore(deps): updated graphql-js version to support 0.10.0 #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DxCx
suggested changes
May 28, 2017
There was a problem hiding this comment.
Thanks @dotansimha
2 comments:
- We usually support latest 2 versions which means 0.8.0 can be removed.
- If endpointURL starts with ws:// we should use just websocket and not mixed.. :)
| @@ -70,7 +70,7 @@ export function renderGraphiQL(data: GraphiQLData): string { | |||
| <script src="//cdn.jsdelivr.net/react/15.0.0/react-dom.min.js"></script> | |||
| <script src="//cdn.jsdelivr.net/graphiql/${GRAPHIQL_VERSION}/graphiql.min.js"></script> | |||
| ${usingSubscriptions ? | |||
| '<script src="//unpkg.com/subscriptions-transport-ws@0.5.4/browser/client.js"></script>' + | |||
| '<script src="//unpkg.com/subscriptions-transport-ws@0.7.0/browser/client.js"></script>' + | |||
There was a problem hiding this comment.
Lets put under const like graphiql version. Also, graphiql version can be updated to 0.10.2
|
1 - Done |
|
Yess, this is great! 🎉 Can't wait for this to land to try the new subscriptions stuff 😊 |
|
well, you rushed to merge it but this is incomplete: packages will still use 0.9.2 for testing... |
DxCx
reviewed
May 28, 2017
| @@ -24,7 +24,7 @@ | |||
| }, | |||
| "homepage": "https://github.com/apollostack/graphql-server#readme", | |||
| "peerDependencies": { | |||
| "graphql": "^0.8.0 || ^0.9.0" | |||
| "graphql": "^0.8.0 || ^0.9.0 || ^0.10.0" | |||
There was a problem hiding this comment.
hey @dotansimha you forgot to align with others :)
Merged
This was referenced May 30, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updated
subscriptions-transport-wsversion to the latest.TODO: