-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.8.1 #425
Conversation
Oh, now I see what's going on. I thought it was my mistake, but Lerna is auto-updating dependencies. Well how nice of Lerna ... 🙄 Fibers v2 does't compile on Node 4, so we can't update it as long as we want to keep support for Fibers. Trying to find out how to keep Lerna from doing that, but might have to resume tomorrow. |
"fibers": "^1.0.15", | ||
"meteor-promise": "^0.8.2" | ||
"@types/graphql": "^0.9.1", | ||
"fibers": "^2.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line here is the problem. Fibers should not be updated. We might have to use a specific version range >= 1.0.15 < 2.0.0 here, but I don't know if that would work, and to test it we either have to dig through the lerna source, or try a new release...
Maybe we can downgrade to a version of lerna that doesn't do the auto-updating. |
@helfer does it happen even if you request specified version? |
Well, now that's clearly a bug and not consistent with the lerna docs... Updating fibers=1.0.15 to 2.0.0 |
Ah, I found the issue. It has nothing to do with Lerna at all. It's the |
Ohh right, sorry i forgot about that, but yeah, back then we had some issue
after release and it happend because one of the inner packages was not
updated by greenkeeper.
Anyway, we decided together on this behavior after it happened, we just
both forgot about it :)
…On Wed, 14 Jun 2017 at 5:11 Jonas Helfer ***@***.***> wrote:
Ah, I found the issue. It has nothing to do with Lerna at all. It's the
prerelease script in package.json. @DxCx <https://github.com/dxcx> what
was the rationale for adding check-updates to the lerna release cycle?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#425 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABB8W2H5alUect9dQ0DX6CbsxA3G0ApDks5sD0FFgaJpZM4N4CWs>
.
|
This reverts commit 90a9ec7.
Haha, I guess we both forgot about it! Well I've removed it for now because it was causing problems with fibers. We'll need to find another way to keep dependencies updated if we can't pin a certain version. In any case, I think we should run the version updates manually so we can fix them by hand if necessary. |
Thanks to @DxCx for fixing a bug where queries over HTTP GET would not go through validation.