Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update apollo-link to be a greater than, rather than a specific version #765

Merged
merged 4 commits into from
Jul 19, 2018

Conversation

orta
Copy link
Contributor

@orta orta commented May 1, 2018

If you're using TypeScript, this ties the type definition for apollo-link to be specifically the version at 1.2.1 and if you have a less vague option in app-code then the two can not match (which is awesome, and totally the point)

I assume that the tie to an exact version was likely a oversight, so this lets resolver potentially not just be one version.

@freiksenet
Copy link
Contributor

Typescript fails with higher version of apollo-link, thus the lock.

@stubailo stubailo merged commit 42c6594 into ardatan:master Jul 19, 2018
@stubailo
Copy link
Contributor

Thanks a lot @orta looks like the typescript thing is no longer an issue 🙂

@orta
Copy link
Contributor Author

orta commented Jul 20, 2018

Doh - sorry for leaving the PR hung

@stubailo
Copy link
Contributor

stubailo commented Aug 1, 2018

No problem at all! published in 3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants