require in .mjs files

[jaydenseric]

It is invalid for require to appear in .mjs files. This is currently happening in distributed files:

Version

• react-apollo@^2.1.0-beta.0

[rosskevin]

Regarding require, there are a few in the codebase for legacy imports, where that is the only way to typescript-appropriately import, other than that the rest are import syntax.

import x = require() syntax won't work based on our tsconfig module, but import * as x or import x also won't work because these are commonjs modules that use module.exports = x.

If you can figure out how to import these and have tsc be happy - I'm happy to know that solution.

[rosskevin]

It looks like #1617 will solve the requires.

[jaydenseric]

Kind of related: babel/babel#7294. There is a workaround I have shipped in apollo-upload-server, to get native ESM and fallback CJS build targets to work from a common ES6 source that imports a third party CJS module.

[leoasis]

Does .mjs allow importing common js .js files? If the answer is yes, then maybe we could wrap the packages and provide a default (or named) export, something like this:

// some_file.mjs
import invariant from './invariant';
...

// invariant.js
exports.default = require('invariant');

[hwillson]

.mjs support was removed. Thanks!

[AgronKabashi]

This is unfortunately still an issue when bundling with Rollup.
I don't see why the change was reverted as apollo-client was suffering from the same issue but they got it working here: https://github.com/apollographql/apollo-client/pull/4158/files.

[rosskevin]

We have a new esm build already merged and will be released next.