Skip to content
This repository has been archived by the owner on Apr 14, 2023. It is now read-only.

Make sure this package exports something to add subscriptions to Apollo Client #38

Closed
stubailo opened this issue Oct 20, 2016 · 5 comments

Comments

@stubailo
Copy link
Contributor

https://medium.com/apollo-stack/graphql-subscriptions-in-apollo-client-9a2457f015fb#.37xz9hr75

Reported by @mlp5ab from scaphold

@drFabio
Copy link

drFabio commented Oct 21, 2016

Following the blog now and was searching the code because this part was not working. So the medium post said that there was an exported function that does not exist or the function goes by a different name now? Searched the code for addGraphQLSubscriptions and it reported nothing does this function exist somewhere or the post was an spec ?

@helfer
Copy link
Contributor

helfer commented Oct 21, 2016

@drFabio yeah, it should be here but we forgot to include it. For the time being you can copy-paste it out of GitHunt-React.

@stubailo stubailo changed the title Make sure this package imports something to add subscriptions to Apollo Client Make sure this package exports something to add subscriptions to Apollo Client Oct 21, 2016
@anhldbk
Copy link

anhldbk commented Nov 27, 2016

@helfer Open for a PR against this issue?

@helfer
Copy link
Contributor

helfer commented Nov 29, 2016

@anhldbk yes, definitely!

@Urigo
Copy link
Contributor

Urigo commented Feb 5, 2017

Implemented in this PR: #64 (thanks @Darkbladecr), and I will release a new version in the next couple of minutes

@Urigo Urigo closed this as completed Feb 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants