fix: Ignore edits/creations for non file documents #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgzuke
force-pushed
the
jgzuke/fix/fix-reading-non-file-documents
branch
from
cc6c69f to
27bde99
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ignores document edits/creations that are coming from non file sources (eg merge view documents).
Previously if you opened the diff viewer (and possibly other ephemeral documents) the extension would see multiple definitions with the same name and crash.
Adapted from: apollographql/apollo-tooling#1894
Fixes: apollographql/apollo-tooling#1789, apollographql/apollo-tooling#1875, part of #18