fix: Fix syntax highlighting for implements with directive #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```grqphql type Product implements ProductItf @key(fields: "id") @key(fields: "sku package") @key(fields: "sku variation { id }") { … } ``` would previously not follow the pattern `"begin": "\\s*\\b(implements)\\b\\s*", "end": "\\s*(?={)",` because the `implements ProductItf` was followed by an ‘@’, not a ‘{’ (which is perfectly valid)
jgzuke
deleted the
jgzuke/fix/fix-syntax-highlighting-for-implements-with-directive
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
would previously not follow the pattern
"begin": "\\s*\\b(implements)\\b\\s*", "end": "\\s*(?={)",because theimplements ProductItfwas followed by an ‘@’, not a ‘{’ (which is perfectly valid). This meant this was not getting recognized as an interface.You might be asking, why do we have our own full grammar defined here when it probably isn't up to date with the spec, there must be a better way 💭 Agree, but let's fix this issue for now 😛
A few other random small cleanups here as well. The first commit is the functional change.