Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support type: module with .cjsfile extension #4

Merged
merged 3 commits into from
Aug 11, 2021
Merged

fix: support type: module with .cjsfile extension #4

merged 3 commits into from
Aug 11, 2021

Conversation

alexanderniebuhr
Copy link
Contributor

@alexanderniebuhr alexanderniebuhr mentioned this pull request Jul 22, 2021
Merged
4 tasks
@alexanderniebuhr
Copy link
Contributor Author

alexanderniebuhr commented Aug 9, 2021 •
edited
Loading

i do understand if you do not want to add support for esm yet, but this commit just allows cjs support with an additional file extension. This is a major break for us, why we have to run our custom builded version of this extension

/cc @jgzuke @cy

@cy
Copy link
Contributor

cy commented Aug 11, 2021

Looks reasonable, thank you @alexanderniebuhr

@cy cy merged commit 5036d49 into apollographql:main Aug 11, 2021
@cy cy mentioned this pull request Aug 11, 2021
Merged
@alexanderniebuhr
Copy link
Contributor Author

sorry for missing prettier run. I guess I missed it, because I ported this PR.

@alexanderniebuhr alexanderniebuhr deleted the alexanderniebuhr/add-cjs-support branch August 12, 2021 05:56
@alexanderniebuhr alexanderniebuhr mentioned this pull request Aug 12, 2021
Closed
@github-actions github-actions bot mentioned this pull request Oct 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexanderniebuhr @cy