-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Apollo Redux actions to be namespaced #210
Comments
We might want to loop this in with a different breaking change since it doesn't seem to be worth a minor version bump on its own. |
I totally agree. We should namespace. |
|
Guess we're going with |
ALRIGHT, assign to me? I got you |
Is a global APOLLO with things like APOLLO.* worth consideration? |
These action types aren't really for consumers. They're part of the internal api for the client. |
@MasterJames this is about namespacing Redux action types, which are just strings, and don't have a standard namespacing schemes. |
@abhiaiyer91 do you think we should consider this a breaking change? We didn't really document the action names before, so maybe it isn't? Hard to say. |
Its not breaking to any users. Unless people are relying on these action types in their apps? @jbaxleyiii do you guys? |
Yeah if they don't then it's probably fine |
@stubailo @abhiaiyer91 we don't! |
Alright abhi go for it! |
Food for thought but probably not related enough to reconsider dotting at least. |
Done! |
Thanks @abhiaiyer91! Great work. |
Right now our actions are called stuff like
QUERY_RESULT
, etc. That might result in a collision with actions someone might already have in their app. We might want to namespace our actions with a prefix that contains the nameAPOLLO
, which will make collisions basically impossible.The text was updated successfully, but these errors were encountered: