Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "metadata" argument to watchQuery #1010

Merged
merged 1 commit into from
Dec 8, 2016
Merged

Add "metadata" argument to watchQuery #1010

merged 1 commit into from
Dec 8, 2016

Conversation

glasser
Copy link
Member

@glasser glasser commented Dec 8, 2016 •
edited
Loading

  • If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes) — Discussed in person with @stubailo
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change
  • Add your name and email to the AUTHORS file (optional)
  • If this was a change that affects the external API, update the docs and post a link to the PR in the discussion

Libraries such as react-apollo can pass metadata with their queries,
which can be read by tools such as the Apollo Chrome DevTools.

@glasser glasser requested a review from stubailo December 8, 2016 00:11
@zol zol added the in progress label Dec 8, 2016
@glasser glasser force-pushed the glasser/watch-metadata branch 4 times, most recently from 75ceaad to f75694a Compare December 8, 2016 00:29
glasser added a commit to apollographql/react-apollo that referenced this pull request Dec 8, 2016
@glasser
Pass component display name to watchQuery metadata.
01dcb2f 
Metadata is a new feature added in apollographql/apollo-client#1010
@glasser glasser force-pushed the glasser/watch-metadata branch from f75694a to 10ff17f Compare December 8, 2016 00:37
@glasser glasser mentioned this pull request Dec 8, 2016
Merged
6 tasks
glasser added a commit to apollographql/react-apollo that referenced this pull request Dec 8, 2016
@glasser
Pass component display name to watchQuery metadata.
953734e 
Metadata is a new feature added in apollographql/apollo-client#1010
helfer
helfer approved these changes Dec 8, 2016
View reviewed changes
Copy link
Contributor

@helfer helfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Would you like me to merge this and release a new version for you guys?

@glasser
Copy link
Member Author

glasser commented Dec 8, 2016

That would be great, if you're still around today!

@helfer
Copy link
Contributor

helfer commented Dec 8, 2016

@glasser: sure thing! I'll do it when I get back from dinner in about an hour or so.

@glasser @helfer
Add "metadata" argument to watchQuery
45a15f0 
Libraries such as react-apollo can pass metadata with their queries,
which can be read by tools such as the Apollo Chrome DevTools.
@helfer helfer force-pushed the glasser/watch-metadata branch from 10ff17f to 45a15f0 Compare December 8, 2016 20:52
@helfer helfer merged commit 2e79404 into master Dec 8, 2016
@helfer helfer deleted the glasser/watch-metadata branch December 8, 2016 20:59
@helfer helfer removed the in progress label Dec 8, 2016
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@helfer helfer helfer approved these changes

@stubailo stubailo Awaiting requested review from stubailo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@glasser @helfer @zol