Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devtools hook #1017

Merged
merged 7 commits into from
Dec 9, 2016
Merged

Devtools hook #1017

merged 7 commits into from
Dec 9, 2016

Conversation

stubailo
Copy link
Contributor

@stubailo stubailo commented Dec 9, 2016

TODO:

  • If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change
  • Add your name and email to the AUTHORS file (optional)
  • If this was a change that affects the external API, update the docs and post a link to the PR in the discussion

@stubailo
Copy link
Contributor Author

stubailo commented Dec 9, 2016

Requested change from glasser: Add an option to override default attaching to window.

@stubailo stubailo merged commit 1788ab1 into master Dec 9, 2016
@helfer helfer deleted the devtools-hook branch December 13, 2016 05:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant