Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken state with errors null #1208

Merged
merged 6 commits into from
Jan 22, 2017
Merged

Fix broken state with errors null #1208

merged 6 commits into from
Jan 22, 2017

Conversation

calebmer
Copy link
Contributor

@calebmer calebmer commented Jan 20, 2017 •
edited
Loading

Fixes #1185 and includes @tmeasday’s test in #1197.

  • If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change

@calebmer calebmer changed the title Fix/broken state with errors null Fix broken state with errors null Jan 20, 2017
@calebmer calebmer mentioned this pull request Jan 20, 2017
Closed
@helfer
Copy link
Contributor

helfer commented Jan 22, 2017

👍

@helfer helfer mentioned this pull request Jan 22, 2017
Closed
@helfer helfer merged commit d76e1b1 into master Jan 22, 2017
@helfer helfer deleted the fix/broken-state-with-errors-null branch January 22, 2017 05:18
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calebmer @helfer @tmeasday