Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure diffing and printing works with multiple root queries #185

Merged
merged 3 commits into from
May 7, 2016
Merged

Make sure diffing and printing works with multiple root queries #185

merged 3 commits into from
May 7, 2016

Conversation

stubailo
Copy link
Contributor

@stubailo stubailo commented May 7, 2016 •
edited
Loading

Fixes:

  1. Multiple queries react-apollo#45
  2. Query printer can't print mutliple root queries after diffing #184

TODO:

  • Fix diffing regression and write test
  • Fix printing to work and write test
  • Update CHANGELOG.md with your change
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

@mattiasewers this is the fix about your issue, should be done soon!

@stubailo stubailo merged commit 391d1bf into master May 7, 2016
@jbaxleyiii jbaxleyiii deleted the multiple-root branch May 17, 2016 02:04
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
🐞 bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@stubailo