Resolve stopQuery/broadcastQueries race condition #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add check for `listener` in QueryManager's `broadcastQueries()` It is possible the deletion of a query listener in `stopQuery()` and the `forOwn` iteration of query listeners in `broadcastQueries()` to overlap, causing a race condition. This commit explicitly checks that the listener exists before attempting to invoke it.
|
@bruce: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
|
Looks great, thank you for identifying this race condition! |
jbaxleyiii
pushed a commit
that referenced
this pull request
Oct 18, 2017
Update auth.md - add info about "withApollo"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure all of the significant new logic is covered by tests(Small change to avoid race condition, hard to effectively reproduce in tests.)Fix for #231.
listenerin QueryManager'sbroadcastQueries()It is possible the deletion of a query listener in
stopQuery()and the
forOwniteration of query listeners inbroadcastQueries()tooverlap, causing a race condition. This explicitly checks that
the listener exists before attempting to invoke it.