Basic polling query alignment #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…val are batched together
Poincare
force-pushed
the
basic_alignment
branch
from
1c829a9 to
4ad080f
Compare
Poincare
changed the title
|
@stubailo ready for review |
stubailo
force-pushed
the
basic_alignment
branch
from
d781038 to
72fc582
Compare
| if (!options.pollInterval) { | ||
| throw new Error('Attempted to start a polling query without a polling interval.'); | ||
| } | ||
|
|
||
| if (!queryId) { | ||
| queryId = this.queryManager.generateQueryId(); |
Poincare
force-pushed
the
basic_alignment
branch
from
72fc582 to
d5b7fc4
Compare
|
@stubailo ready for review |
| @@ -3,11 +3,31 @@ | |||
| Expect active development and potentially significant breaking changes in the `0.x` track. We'll try to be diligent about releasing a `1.0` version in a timely fashion (ideally within 3 to 6 months), to signal the start of a more stable API. | |||
|
|
|||
| ### vNEXT | |||
| <<<<<<< HEAD | |||
There was a problem hiding this comment.
It looks like we have committed a merge conflict
|
|
||
| if (options.pollInterval) { | ||
| if (options.noFetch) { | ||
| throw new Error('noFetch option should not use query polling.'); |
There was a problem hiding this comment.
@Poincare we lost this code in the merge, it seems
This was referenced Jul 20, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a really simple method of aligning polling queries. In most applications, there are may be queries that operate on exactly the same interval. The scheduler will fire these on the same interval meaning that the queries will be batched automatically by the batcher. Solves #401.
TODO: