Mutation reducers #404
Merged
Mutation reducers #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Slava
commented
Jul 15, 2016
•
Slava
commented
- Update CHANGELOG.md with your change
- Make sure all of the significant new logic is covered by tests
- Rebase your changes on master so that they can be merged easily
- Make sure all tests and linter rules pass
Slava
force-pushed
the
mutation-reducers
branch
2 times, most recently
from
29a50d3 to
77551cf
Compare
|
this pr no longer relies on #400 |
| - Added a "noFetch" option to WatchQueryOptions that only returns available data from the local store (even it is incomplete). [Issue #225](https://github.com/apollostack/apollo-client/issues/225) and [PR #385](https://github.com/apollostack/apollo-client/pull/385). | ||
| - Introduce a new (preferable) way to express how the mutation result should be incorporated into the store and update watched queries results: `updateQueries`. [PR #404](https://github.com/apollostack/apollo-client/pull/404). |
There was a problem hiding this comment.
I'd also add a new changelog entry that we made writing query results to store more efficient since they maintain object references in the case where data didn't change.
|
Looks great to me, just a few comments. Actually really hyped about how little code this was! |
|
Also needs to be rebased |
Slava
added a commit
that referenced
this pull request
Jul 18, 2016
In response to Sashko's code review #404
Slava
added a commit
that referenced
this pull request
Jul 18, 2016
In response to Sashko's code review #404
In response to Sashko's code review #404
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.