Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the fragment flattening #437

Merged
merged 4 commits into from
Jul 20, 2016
Merged

Added the fragment flattening #437

merged 4 commits into from
Jul 20, 2016

Conversation

Poincare
Copy link
Contributor

@Poincare Poincare commented Jul 20, 2016 •
edited
Loading

Added fragment definition flattening as per the discussion in #421 and a test for it.
(also, this branch's name is misspelled).

TODO:

  • Update CHANGELOG.md with your change
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

@stubailo
Copy link
Contributor

What's misspelled?

@stubailo
Copy link
Contributor

Seems legit!

@Poincare
Copy link
Contributor Author

Poincare commented Jul 20, 2016 •
edited
Loading

The name of the branch on this repo, i.e. "flattening"
screen shot 2016-07-20 at 3 40 53 pm

@stubailo
Copy link
Contributor

I think that's the right spelling! https://www.google.com/webhp?sourceid=chrome-instant&ion=1&espv=2&ie=UTF-8#q=flattening

@stubailo stubailo merged commit d3075a9 into master Jul 20, 2016
@Poincare Poincare mentioned this pull request Jul 20, 2016
Closed
@stubailo stubailo deleted the fragment_flattening branch September 20, 2016 03:42
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Poincare @stubailo