Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor network interface: move query merging to separate package #734

Merged
merged 9 commits into from
Oct 3, 2016
Merged

Refactor network interface: move query merging to separate package #734

merged 9 commits into from
Oct 3, 2016

Conversation

helfer
Copy link
Contributor

@helfer helfer commented Oct 2, 2016 •
edited
Loading

TODO:

  • If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change
  • Add your name and email to the AUTHORS file (optional)
  • If this was a change that affects the external API, update the docs and post a link to the PR in the discussion

stubailo
stubailo reviewed Oct 3, 2016
View reviewed changes
CHANGELOG.md
@@ -5,6 +5,7 @@ Expect active development and potentially significant breaking changes in the `0
### vNEXT

- **Feature removal**: Remove query diffing functionality to make client more predictable and simplify implementation. Queries will still read from the store, and if the store does not have all of the necessary data the entire query will fetch from the server. Read justification and discussion in [Issue #615](https://github.com/apollostack/apollo-client/issues/615) [PR #693](https://github.com/apollostack/apollo-client/pull/693)
- ** Breaking change **: Move batching to network interface and split off query merging into separate package [PR #734](https://github.com/apollostack/apollo-client/pull/734)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe remove the spaces inside **, seems to mess up highlighting

@helfer helfer force-pushed the refactor-query-merging branch from 5d69d89 to 9586e98 Compare October 3, 2016 18:08
@helfer helfer merged commit d9269e5 into master Oct 3, 2016
@helfer helfer removed the in progress label Oct 3, 2016
@stubailo stubailo deleted the refactor-query-merging branch October 15, 2016 22:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stubailo stubailo stubailo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@helfer @stubailo