-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass custom header in GraphiQL #133
Conversation
I think it would be better to add an option to do this rather than hard coding a meteor specific solution. |
@stubailo It's ok now? I also made a PR https://github.com/apollostack/meteor-integration/pull/35/files that passes the meteor authorization header automatically. |
I think we can merge this, because it's a simple way to get authorization, but it's a very hacky solution, so I'd rather not document it prominently. |
Thanks @nicolaslopezj |
@nicolaslopezj I just realized that there's no test for this code. Would you mind making another PR that adds a test? Thanks! |
Included in https://github.com/apollostack/apollo-server/blob/master/CHANGELOG.md#v030 |
@helfer, AFAIK this is the easiest way to get authentication for a Graphiql client. Hacky or not, I think it would make a lot of people's lives much easier (including mine!) How can we upgrade this feature to make it "not hacky"? |
I think it is best to open a new issue about it. |
Update @apollo/gateway dependency
Update @apollo/gateway dependency
This passes the Meteor login token in the authorization header so magically we are connected with the logged in user in GraphiQL.
I wanted to make a solution that fits all types of Apps, not only Meteor. But I couldn't find a non-hacky way to pass headers to the fetch function.
So as a second option we could pass a string to renderGraphiQL (setting it in the options when creating the server) that we later put into the GraphiQL document string, like this:
I don't like this solution very much but it works with non Meteor Apps