Catch formatError #174
Merged
Catch formatError #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stubailo
reviewed
Oct 17, 2016
| return options.formatError(error); | ||
| } catch (err) { | ||
| console.error('Error in formatError function:', err); | ||
| return formatError(error); |
There was a problem hiding this comment.
People might be using formatError to hide some information, for example maybe they don't want the error message to leak to the client. I'd suggest the best option is to return a generic "Internal server error" message instead.
|
Looks great to me, thanks! |
trevor-scheer
pushed a commit
that referenced
this pull request
May 6, 2020
trevor-scheer
pushed a commit
that referenced
this pull request
May 14, 2020
trevor-scheer
pushed a commit
that referenced
this pull request
Oct 17, 2022
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
trevor-scheer
pushed a commit
that referenced
this pull request
Oct 17, 2022
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
trevor-scheer
pushed a commit
that referenced
this pull request
Oct 19, 2022
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When formatError throws an error, the request nevers responds. In this PR I add try/catch to formatError and use the default one if the provided fails.
This fixes #171
TODO: