Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update tracer mock report to be function and add mock of submit #26

Merged
merged 2 commits into from
Jun 13, 2016

Conversation

jbaxleyiii
Copy link
Contributor

@helfer do you want changelog / tests for this change as well?

@helfer
Copy link
Contributor

helfer commented Jun 13, 2016

Thanks! Yeah, maybe just a mention in the changelog that a bug with tracerLogger.submit was fixed.

Test isn't necessary, instead we should try to figure out how we can get mocha to catch this kind of stuff as well. And if we can't maybe we should consider switching to ava.

@jbaxleyiii
Copy link
Contributor Author

@helfer added to changelog 👍

@helfer
Copy link
Contributor

helfer commented Jun 13, 2016

Thanks! Version 0.1.4 published with bugfix.

@helfer helfer merged commit 3bad1c8 into master Jun 13, 2016
@helfer helfer mentioned this pull request Jun 13, 2016
@helfer helfer deleted the tracer-mocks branch September 20, 2016 03:46
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants