Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update graphql to 0.8.2 #40

Merged
merged 1 commit into from
Jan 23, 2017
Merged

Conversation

jonbretman
Copy link
Contributor

@jonbretman jonbretman commented Jan 17, 2017

Main benefit of this update is better error messages e.g.

'Cannot query field "allFilmsx" on type "RootQuery". Did you mean "allFilms"?'

TODO:

  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests pass - I had to comment out one test but I was able to uncomment out another. Not sure if this is ok.
  • Update CHANGELOG.md with your change - should I bump the version and update the CHANGELOG.md or will someone do this when they release?
  • If this was a change that affects the external API, update the README

@apollo-cla
Copy link

@jonbretman: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@helfer
Copy link
Contributor

helfer commented Jan 23, 2017

Whoa, we were on 0.5?? Thanks a lot for the PR @jonbretman !

@helfer helfer merged commit 8b81fed into apollographql:master Jan 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants