Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion filtering ignores+removes 'highlight' from ElasticSearch hits #52

Open
jogam opened this issue Nov 27, 2019 · 0 comments
Open

Comments

@jogam
Copy link

jogam commented Nov 27, 2019

ReactiveSearch.DataSearch component provides properties for customHighlight and parseSuggestion to customise suggestions for current search input. Unfortunately it appears the highlight entry of the returned ES hits are being neglected/discarded during the query result processing here. (the customHighlight query configuration is properly included in the query sent to ES though!)

Maybe I miss something but it seems to be caused by calling getSuggestions of this packages utils/suggestions.js module as can be seen in onSuggestions( query.result ) call here for WEB Version or Vue.js Version.

If the above is true, would it be possible to add/maintain highlight either as new field in suggestions option dict, e.g. suggestion.highlight or as entry in the suggestion.source field e.g. suggestion.source._highlight?

NOTE: highlight may? not be present in hits/query result if customHighlight is not configured

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant