This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
Add TestingBot as Cloud Provider #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Please provide a screenshot of how this will look. There are also conflicts in your branch. |
|
Conflicts have been resolved. Screenshot: |
jlipps
reviewed
Mar 13, 2019
…n.js + make sure we provide the necessary strings for translation
|
Thanks for the reviews! I've updated the pull request. |
|
Thanks for the additional reviews, I've updated the pull request with the necessary i18n changes. |
| const {server, setServerParam, t} = this.props; | ||
|
|
||
| const testingbotKeyPlaceholder = process.env.TB_KEY ? | ||
| t('usingDataFoundIn', {environmentVariable: 'TB_KEY'}) : t('yourUsername'); |
There was a problem hiding this comment.
Where usingDataFoundIn and yourUsername resources are defined?
There was a problem hiding this comment.
@mykola-mokhnach they are defined in
There was a problem hiding this comment.
mykola-mokhnach
approved these changes
Mar 19, 2019
|
@testingbot thanks for the contribution! I noticed that TestingBot is based in Belgium. I don't suppose you have any French speakers who would be interested in helping with localization? |
triager
pushed a commit
that referenced
this pull request
Mar 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds TestingBot as a Cloud Provider.
Please let me know if any changes are required.