Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Only restart springboard if the system language is changed #388

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

mykola-mokhnach
Copy link
Contributor

I assume there is no need to restart springboard if only keyboard or locale changes are applied.

Relates to appium/appium#19202

cc @mwakizaka

Copy link
Member

@KazuCocoa KazuCocoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me

@mwakizaka
Copy link
Contributor

Thank you. It makes sense. Btw, how about checking SBRecentLocale value of xcrun simctl spawn booted defaults read com.apple.springboard as well? I mean, we don't need to call xcrun simctl spawn booted launchctl stop com.apple.SpringBoard if the SpringBoard is already translated into the specified language.

% xcrun simctl spawn booted defaults read com.apple.springboard
{
    ...
    SBParentalControlsMCContentRestrictions =     {
        countryCode = "";
    };
    SBRecentLocale = "ja-JP";
    ...
}

@mykola-mokhnach
Copy link
Contributor Author

Thank you. It makes sense. Btw, how about checking SBRecentLocale value of xcrun simctl spawn booted defaults read com.apple.springboard as well? I mean, we don't need to call xcrun simctl spawn booted launchctl stop com.apple.SpringBoard if the SpringBoard is already translated into the specified language.

This would be even more sophisticated approach. My assumption is that if someone has already provided some language value then most likely they want it to change rather than keep as is.

@mykola-mokhnach mykola-mokhnach merged commit 99e3ae5 into appium:master Sep 26, 2023
7 checks passed
@mykola-mokhnach mykola-mokhnach deleted the kbd_check branch September 26, 2023 05:04
github-actions bot pushed a commit that referenced this pull request Sep 26, 2023
## [5.3.3](v5.3.2...v5.3.3) (2023-09-26)

### Bug Fixes

* Only restart springboard if the system language is changed ([#388](#388)) ([99e3ae5](99e3ae5))
@github-actions
Copy link

🎉 This PR is included in version 5.3.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants