Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate core as core ruby gem #665

Closed
1 of 3 tasks
KazuCocoa opened this issue Sep 18, 2017 · 12 comments
Closed
1 of 3 tasks

separate core as core ruby gem #665

KazuCocoa opened this issue Sep 18, 2017 · 12 comments
Milestone

Comments

@KazuCocoa
Copy link
Member

KazuCocoa commented Sep 18, 2017

This is a

  • Bug report
  • Question
  • Freature Request

Summary

  • separate lib/appium_lib/core

working

@KazuCocoa
Copy link
Member Author

After considering and update touch action related method, I'll proceed this issue.

@KazuCocoa
Copy link
Member Author

KazuCocoa commented Oct 28, 2017

@appium/admins
Could you create a new repository named ruby_lib_core under the Appium organisation? I'd like to move some of the code from https://github.com/KazuCocoa/appium_lib_core to the repository.

I'm working to separate current ruby_lib to core, minimal Appium ruby client library, and extended helpful methods, include SauceLabs, part. ( refine Appium ruby binding #602 ). This change will help maintain webdriver-related issue(catch up with webdriver-side changes) and Appium side changes.

For end-users, they can continue to use ruby_lib. And if anyone would like to integrate Appium related features to their library, they can use the core part and extend any methods as their favourite way.

@KazuCocoa
Copy link
Member Author

@jlipps Could you take a look at ^ when you have a time?
Thanks.

@jlipps
Copy link
Member

jlipps commented Oct 31, 2017

@KazuCocoa https://github.com/appium/ruby_lib_core. Do you have access already?

@KazuCocoa
Copy link
Member Author

KazuCocoa commented Oct 31, 2017

@jlipps
Thanks!
No, it looks I have no access to the repository. I could create an issue but couldn't set labels, for example.

@jlipps
Copy link
Member

jlipps commented Nov 2, 2017

@KazuCocoa ok I added ruby_lib_core to the committers team, you should now have access. sorry for the delay!

@KazuCocoa
Copy link
Member Author

Thanks! But I haven't merged and assigned, etc, yet.

Could you check the permission again? @jlipps

image

@jlipps
Copy link
Member

jlipps commented Nov 3, 2017

Sorry looks like I had to explicitly give Write access, @KazuCocoa. Can you try again?

@KazuCocoa
Copy link
Member Author

Thanks! I could. 👍

@KazuCocoa
Copy link
Member Author

@jlipps
Could you enable Travis? Since I have no permission to add it.
https://travis-ci.org/appium/ruby_lib_core

@jlipps
Copy link
Member

jlipps commented Nov 6, 2017

@KazuCocoa ok it's enabled

@KazuCocoa KazuCocoa added this to the v10.0? milestone Nov 7, 2017
@KazuCocoa
Copy link
Member Author

Thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants