-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ship Swift Atomics 1.1 #79
Comments
Building using xcodebuild with library evolution enabled currently breaks due to #54, under Swift 5.7.1 (and 5.8). We will have to live with this for now.
|
TSan tests are failing on Ubuntu with signal 9. I'm ignoring this. |
|
Evidently Swift Atomics has been quietly failing on Windows since forever. (#56, swiftlang/swift#60534, swiftlang/swift-installer-scripts#144) My own Windows testing is blocked on elementary problems with Swift packages on my Windows box that I don't really have time or energy to investigate.
|
Ah, reinstalling VS2019 & Swift 5.9 restored SwiftPM to working order. Windows platform support continues to be blocked on #56. Ignoring. |
Windows support for Swift Atomics 1.0.x did work with VS 2022, but I’m not sure if 1.1 breaks it again. We’ll try to solve the problem in |
I got further! My steps, for posterity:
This happens both on |
Interesting… What about |
Here goes!
|
I cannot reproduce it with Swift 5.7.3🤔️ With VS 17.5.3 and Swift 5.7.3, you don’t even need the I suspect this could be some Swift 5.8 regression. |
Huh. I also see this error with 5.7.3, so presumably something is messed up on my end. Can I delegate the testing to you? 🙈 Do these pass for you on 5.7.3?
The need for custom installation steps will preclude Windows from being a supported platform, but it would be good to know if the underlying code will eventually work! |
Hm,
This is an Xcode issue (or perhaps a problem in the test script). Ignoring. |
AFAIK VS 2022 (17.5+) actually eliminates the need for it. A fix through the installer is still desired anyway. We may need to clarify that at the moment we need VS 17.5+ on Windows.
|
That is excellent news! I'll include some text announcing experimental Windows support in the release notes. (I really hope we'll soon be able to migrate this package to native atomic intrinsics -- that should eliminate all of the C-related headaches.) |
I think I'll do most Intel testing on macOS via Rosetta, with limited testing on an actual Intel CPU on Monday. |
Oops:
|
Oh, that's unfortunate. Windows definitely requires CMPXCHG16B these days, so this must be due to the C stdlib not getting updated. Native atomics should solve that, eventually. |
|
|
Ah, my TSan tests on Linux appear to be failing because they're running out of memory, and the process gets killed by the kernel. 💡Fair enough. |
OK, testing complete; 1.1 is ready to get tagged. |
Just wanted to mention that I ran into this recently in Xcode 15 and a quick workaround that I found was to use the non-Simulator variant.
Also works in tandem with
|
Candidate commit: 6c89474
Diff: 1.0.3...main
Testing progress: (On Mac and Linux, this is done by running
Utilities/run-full-tests.sh
. This script builds and tests this package using various build systems and build configurations.)macOS/AS
macOS/x86_64
macOS 13.3, x86_64, Xcode 14.3, Swift main (swift.org developer snapshot as of 2023-03-30)(skipped)macOS 13.3, x86_64, Xcode 14.3, Swift 5.9 (swift.org developer snapshot as of 2023-03-30)(skipped)Linux/Aarch64
Linux/x86_64
Ubuntu 22.04, x86_64, Swift main nightly build as of 2023-03-30(skipped)Ubuntu 22.04, x86_64, Swift 5.9 nightly build as of 2023-03-30(skipped)Windows 11/x86_64 (experimental)
Windows 11, x86_64, Swift main nightly build as of 2023-03-28Windows 11, x86_64, Swift 5.8 releaseWindows 11, x86_64, Swift 5.6.3 releaseNote:
Swift 5.8 has not shipped yet; I'll hold testing that for now.The text was updated successfully, but these errors were encountered: