Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI tools necessary for the binary targets proposal #2509

Merged
merged 1 commit into from
Jan 10, 2020
Merged

CLI tools necessary for the binary targets proposal #2509

merged 1 commit into from
Jan 10, 2020

Conversation

hartbit
Copy link
Contributor

@hartbit hartbit commented Jan 10, 2020

No description provided.

@hartbit hartbit requested a review from aciidgh as a code owner January 10, 2020 13:31
@hartbit hartbit requested a review from neonichu January 10, 2020 13:31
aciidgh
aciidgh approved these changes Jan 10, 2020
View reviewed changes
Copy link
Contributor

@aciidgh aciidgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides the one minor comment.

@hartbit hartbit force-pushed the binary-targets-cli branch 2 times, most recently from 5bdf102 to 1dd1f56 Compare January 10, 2020 21:07
@hartbit
Copy link
Contributor Author

hartbit commented Jan 10, 2020

@swift-ci smoke test self hosted

@hartbit
Copy link
Contributor Author

hartbit commented Jan 10, 2020

@swift-ci please smoke test

@hartbit hartbit merged commit 117a575 into swiftlang:master Jan 10, 2020
@hartbit hartbit deleted the binary-targets-cli branch January 12, 2020 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aciidgh aciidgh aciidgh approved these changes

@neonichu neonichu Awaiting requested review from neonichu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hartbit @aciidgh