Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Add] NSAttributedStringBuilder #373

Merged
merged 1 commit into from
Aug 1, 2019
Merged

[Add] NSAttributedStringBuilder #373

merged 1 commit into from
Aug 1, 2019

Conversation

ethanhuang13
Copy link
Contributor

@ethanhuang13 ethanhuang13 commented Jul 31, 2019 •
edited
Loading

Pull Request Description

Replace with a description of this pull request. Instructions for adding
projects are available in the README.

Acceptance Criteria

To be accepted into the Swift source compatibility test suite, a project must:

  • be an Xcode or swift package manager project
  • support building on either Linux or macOS
  • target Linux, macOS, or iOS/tvOS/watchOS device
  • be contained in a publicly accessible git repository
  • maintain a project branch that builds against Swift 4.0 and passes any unit tests
  • have maintainers who will commit to resolve issues in a timely manner
  • be compatible with the latest GM/Beta versions of Xcode and swiftpm
  • add value not already included in the suite
  • be licensed with one of the following permissive licenses:
    • BSD
    • MIT
    • Apache License, version 2.0
    • Eclipse Public License
    • Mozilla Public License (MPL) 1.1
    • MPL 2.0
    • CDDL
  • pass ./project_precommit_check script run

Ensure project meets all listed requirements before submitting a pull request.

@ethanhuang13 ethanhuang13 changed the title Add NSAttributedStringBuilder [Add] NSAttributedStringBuilder Jul 31, 2019
@ethanhuang13
Copy link
Contributor Author

@swift-ci Please test

@clackary
Copy link
Contributor

@swift-ci test

@clackary
Copy link
Contributor

clackary commented Aug 1, 2019

Thanks @ethanhuang13!

@clackary clackary merged commit 00f9166 into swiftlang:master Aug 1, 2019
@ethanhuang13
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clackary clackary clackary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ethanhuang13 @clackary