[wasm] Add WASILibc module and its build support #66539
Merged
+358
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
|
@swift-ci build toolchain |
kateinoigakukun
requested review from
zoecarver,
hyp and
egorzhdan
as code owners
|
@kateinoigakukun, do you mind updating this to remove the |
|
I just tried switching glibc.modulemap to listing the Bionic headers directly and most everything from the compiler validation suite kept working on my Android phone. However, it broke around 70 C++ Interop tests that worked before with the This has to do with the two different @egorzhdan, how do you work around this: don't have any libc++ headers that forward to libc headers in the C++ modulemap? The other failure is some oddity related to @kateinoigakukun, I don't know if you run these C/C++ interop tests on wasm, but everything else in the validation suite worked for me. I can slap up my libc modulemap changes if you guys are interested in trying it with your libc's, particularly @3405691582 and @mhjacobson with the BSDs and maybe @stevapple with Windows. |
|
I've submitted my glibc modulemap changes in #66665, you may want to try something similar with wasi-libc and see if it works. |
[wasi-libc](https://github.com/WebAssembly/wasi-libc) is a libc implementation widely used in WASI toolchains. This patch adds a new module named WASILibc. Some extra emulation libraries are also added as wasi_emulated_xxx.
kateinoigakukun
force-pushed
the
katei/patch-series/wasi-libc-module
branch
from
aa845fb
to
643c7c8
Compare
kateinoigakukun
requested review from
hborla,
slavapestov and
xedin
as code owners
|
Nice, working well with the headers listed in the module map, @kateinoigakukun? @egorzhdan, please review. |
|
@swift-ci Please smoke test |
|
@swift-ci build toolchain |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wasi-libc is a libc implementation widely used in WASI toolchains. This patch adds a new Swift and C module for it to import and use it in Swift code. This module is intentionally separate from the existing
Glibcmodule because wasi-libc is actually based on musl libc.This PR changed ClangImporter also to inject the modulemap and auxiliary header for wasi-libc into VFS to recognize it as well as Glibc.