Use Repository data in Recovery CRD #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #436 +/- ##
=====================================
Coverage 84% 84%
=====================================
Files 2 2
Lines 25 25
=====================================
Hits 21 21
Misses 2 2
Partials 2 2Continue to review full report at Codecov.
|
added 3 commits
April 18, 2018 12:43
tamalsaha
reviewed
Apr 21, 2018
apis/stash/v1alpha1/validator.go
Outdated
| strings.HasPrefix(r.Spec.Repository, "replicationcontroller.") || | ||
| strings.HasPrefix(r.Spec.Repository, "replicaset.") || | ||
| strings.HasPrefix(r.Spec.Repository, "statefulset.") || | ||
| (strings.HasPrefix(r.Spec.Repository, "daemonset.") && strings.HasSuffix(r.Spec.Repository, nodeName))) { |
There was a problem hiding this comment.
This nodeName check does not work, since operator is running on different node.
tamalsaha
reviewed
Apr 21, 2018
| `Restic` will take backup of the volume periodically with a 1-minute interval. You can verify that backup is taking successfully by, | ||
|
|
||
| ```console | ||
| $ kubectl get repository deployment.stash-demo -o yaml |
There was a problem hiding this comment.
Why not use the new get snapshots to confirm this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enable user to use Repository data in Recovery CRD so that they don't have to repeat backend info.
Task List: