This repository has been archived by the owner on Jan 18, 2021. It is now read-only.
Something needs to be updated because of new Helm version #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joy717
changed the title
tamalsaha
approved these changes
Mar 5, 2019
|
Thanks a lot @joy717 ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, Because this project is based on an old Helm version. But the Helm version is a newer one,
so we need to update some code.
1.
Reason: There are new status for Helm release: Status_PENDING_INSTALL, Status_PENDING_UPGRADE, Status_PENDING_ROLLBACK.
Fixes: Add these status when listing SummarizeReleases with "all=true"
2.
Reason: The API "ListReleases" on Tiller side now is a Stream service for larger response data.
Fixes: Make client using stream service as well as Tiller when listing SummarizeReleases.
3.
Reason: The gRPC's default Message size limit is 4MB. it's too small. now the Tiller's side is 20MB as default for larger data.
Fixes: Make client using 20MB as the default value of MaxCallRecvMsgSize to match Tiller's value.
here is the link for No.3:
helm/helm#3528