Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Knative docs installs out of date #545

Closed
josiemundi opened this issue Mar 24, 2020 · 5 comments · Fixed by #546
Closed

Knative docs installs out of date #545

josiemundi opened this issue Mar 24, 2020 · 5 comments · Fixed by #546
Assignees
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@josiemundi
Copy link

Describe the bug
In the docs, for 'Setting up Knative Serving...' the Istio version is 1.0.7 and the Knative serving install is 0.7.1.

The docs state that this is '(currently the latest version)'. The latest version of Knative serving is 0.13.0.

For Istio, the file that is linked to is out of date, it is now up to 1.5.0, however in their docs they have 1.3.6.

For Knative serving install, there are new install scripts here.

Expected behavior
Up to date install of Knative

Actual behaviour
Out of date install of Knative, which possibly won't work

Environment Details (please complete the following information):
NA

If applicable please specify:
NA

@sympatheticmoose
Copy link
Contributor

sympatheticmoose commented Mar 24, 2020

In https://appsody.dev/docs/using-appsody/building-and-deploying/#deployment-as-a-knative-service we split out local install and other installs, as I recall this was based on the state of the official docs at the time. The knative project used to provide a bunch of different install guides, until there was an effort to consolidate knative/docs#2137. I wonder now whether we could just link out to https://knative.dev/docs/install/any-kubernetes-cluster/ or whether we still need any custom guidance.

@josiemundi
Copy link
Author

Personally, I think linking out to the docs would be fine.

@neeraj-laad
Copy link
Contributor

I Agree, we were only documenting this ourselves as a point in time solution while Knative docs were still evolving. We should avoid documenting aspects owned by other projects as we will always be playing catch up.

@neeraj-laad neeraj-laad added the documentation Improvements or additions to documentation label Mar 25, 2020
@neeraj-laad neeraj-laad added this to the Milestone-19 milestone Mar 25, 2020
@neeraj-laad
Copy link
Contributor

We should just compare the instructions and make sure there is no additional setup that might be needed for Appsody. Though, I doubt that would be the case.

@sympatheticmoose
Copy link
Contributor

Agreed - I think a test with a fresh install following the knative install guide and a quick compare.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants