-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Knative docs installs out of date #545
Comments
In https://appsody.dev/docs/using-appsody/building-and-deploying/#deployment-as-a-knative-service we split out local install and other installs, as I recall this was based on the state of the official docs at the time. The knative project used to provide a bunch of different install guides, until there was an effort to consolidate knative/docs#2137. I wonder now whether we could just link out to https://knative.dev/docs/install/any-kubernetes-cluster/ or whether we still need any custom guidance. |
Personally, I think linking out to the docs would be fine. |
I Agree, we were only documenting this ourselves as a point in time solution while Knative docs were still evolving. We should avoid documenting aspects owned by other projects as we will always be playing catch up. |
We should just compare the instructions and make sure there is no additional setup that might be needed for Appsody. Though, I doubt that would be the case. |
Agreed - I think a test with a fresh install following the knative install guide and a quick compare. |
Describe the bug
In the docs, for 'Setting up Knative Serving...' the Istio version is 1.0.7 and the Knative serving install is 0.7.1.
The docs state that this is '(currently the latest version)'. The latest version of Knative serving is 0.13.0.
For Istio, the file that is linked to is out of date, it is now up to 1.5.0, however in their docs they have 1.3.6.
For Knative serving install, there are new install scripts here.
Expected behavior
Up to date install of Knative
Actual behaviour
Out of date install of Knative, which possibly won't work
Environment Details (please complete the following information):
NA
If applicable please specify:
NA
The text was updated successfully, but these errors were encountered: