Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace github.com/hpcng/golang-x-crypto fork by github.com/ProtonMail/crypto fork #5407

Closed
cclerget opened this issue Jul 1, 2020 · 1 comment

Comments

@cclerget
Copy link
Collaborator

cclerget commented Jul 1, 2020

The fork github.com/hpcng/golang-x-crypto wasn't updated since a long time and could be hard to maintain and is rather sensible. The fork github.com/ProtonMail/crypto provides the missing feature Singularity requires for private key encryption and is pretty much up to date. Additionally one of developers of github.com/ProtonMail/crypto is currently the maintainer of golang.org/x/crypto package, so it seems a better option.

NOTE: require to replace SerializePrivate call by SerializePrivateWithoutSign if the private key is already encrypted

@cclerget cclerget added this to the 3.7.0 milestone Jul 1, 2020
@cclerget
Copy link
Collaborator Author

cclerget commented Nov 3, 2020

Looks like this is not currently possible without slightly break SIF package, not a huge change but github.com/ProtonMail/crypto has a different function prototype for openpgp.CheckDetachedSignature forcing SIF package to also use github.com/ProtonMail/crypto with a replace statement in go.mod which may not be desirable as it would force project importing SIF package to use the replace statement and could be a mess if a project also rely on golang.org/x/crypto package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant