Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

engage overload method does not execute callback #141

Closed
yloeza opened this issue Dec 19, 2017 · 2 comments
Closed

engage overload method does not execute callback #141

yloeza opened this issue Dec 19, 2017 · 2 comments

Comments

@yloeza
Copy link

yloeza commented Dec 19, 2017

This engage overload method is not properly passing down the BooleanCallback argument, instead is just passing null value as the callback param when executing the static engage event.

public static synchronized void engage(Context context, String event, BooleanCallback callback) {
engage(context, event, null, (ExtendedData[]) null);
}

Which will make the a call like the following never executes callback onFinish:

Apptentive.engage(context, event, callback);
@weeeBox weeeBox closed this as completed Dec 19, 2017
@weeeBox weeeBox mentioned this issue Dec 19, 2017
@weeeBox
Copy link
Contributor

weeeBox commented Dec 19, 2017

Hey @yloeza,

Sorry for the issue. The fixed 5.0.1 version should be available on Maven in about 1 hour.

Thanks,

-Alex

@yloeza
Copy link
Author

yloeza commented Dec 19, 2017

Thanks for a quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants