Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Simpler View for Usage Cards #1242

Merged
merged 11 commits into from
Nov 28, 2024

Conversation

ItzNotABug
Copy link
Member

@ItzNotABug ItzNotABug commented Jul 28, 2024

What does this PR do?

Fix view moving out of cards.

Test Plan

Manual.

usage-storage

usage-storage-mobile

Related PRs and Issues

N/A.

Have you read the Contributing Guidelines on issues?

Yes.

Copy link

vercel bot commented Jul 28, 2024

@ItzNotABug is attempting to deploy a commit to the appwrite Team on Vercel.

A member of the Team first needs to authorize it.

@ItzNotABug ItzNotABug marked this pull request as ready for review July 30, 2024 08:46
Copy link

vercel bot commented Jul 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
console-cloud ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2024 2:38pm

Copy link
Member

@ArmanNik ArmanNik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to change the Row component, we have the rowLink component for that

@ItzNotABug
Copy link
Member Author

I don't think we need to change the Row component, we have the rowLink component for that

Thankss!! Missed that component. Should be fine now.

@ItzNotABug ItzNotABug requested a review from ArmanNik August 1, 2024 07:02
@ItzNotABug ItzNotABug requested a review from ernstmul November 26, 2024 09:52
@ArmanNik ArmanNik merged commit 8bbdf8f into appwrite:main Nov 28, 2024
2 checks passed
@ItzNotABug ItzNotABug deleted the fix-view-outside-card-in-usage branch November 28, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants