Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIP-29][Peer monitoring service] #118

Closed
thepomeranian opened this issue May 4, 2023 · 5 comments
Closed

[AIP-29][Peer monitoring service] #118

thepomeranian opened this issue May 4, 2023 · 5 comments

Comments

@thepomeranian
Copy link
Collaborator

thepomeranian commented May 4, 2023

AIP-29 - Peer monitoring service

Summary

This AIP proposes a new “Peer Monitoring” service that operates on Aptos nodes and allows nodes to track, share and monitor peer information and behaviors. The service aims to: (i) improve node latency and performance, by allowing components to make smarter decisions when disseminating and receiving data; (ii) improve operational quality and reliability, by allowing nodes to dynamically work around failures and unstable peers; (iii) improve peer discovery and selection, by providing a foundation for peer bootstrapping and gossip; (iv) improve security, by allowing nodes to better detect and react to malicious peers and bad behaviors; and (v) improve network observability, by gathering and exporting important network information.

Link to AIP: https://github.com/aptos-foundation/AIPs/blob/main/aips/aip-29.md

@ghost
Copy link

ghost commented May 6, 2023

Please consider https://en.wikipedia.org/wiki/Great_Firewall this in and variant like other country, when implement this stuff in near future.

@JoshLind
Copy link
Contributor

JoshLind commented May 9, 2023

Please consider https://en.wikipedia.org/wiki/Great_Firewall this in and variant like other country, when implement this stuff in near future.

@e99243506bigplay, can you elaborate? The peer monitoring service will operate over the existing TCP connections established between each node. Regardless of where/how the node is operating, if it is able to connect to the Aptos network, it will share metadata with other nodes via the existing links (and should be unaffected by node locations and/or firewall rules).

@davidiw
Copy link
Contributor

davidiw commented May 10, 2023

This is great! I think this fits into an informational AIP? Is this something we expect to vote on? Can nodes decide independently to turn this on or off without uniformity in the network? If so, I'd propose we continue to iterate on this doc and get more feedback.

@ghost
Copy link

ghost commented May 11, 2023

Please consider https://en.wikipedia.org/wiki/Great_Firewall this in and variant like other country, when implement this stuff in near future.

@e99243506bigplay, can you elaborate? The peer monitoring service will operate over the existing TCP connections established between each node. Regardless of where/how the node is operating, if it is able to connect to the Aptos network, it will share metadata with other nodes via the existing links (and should be unaffected by node locations and/or firewall rules).

I just afraid censorship play evil on network connection, seems your sound like no such issue about that.

@kinrokinro
Copy link

kinrokinro commented Jun 6, 2023

The main concern is the possibility of divulging any private information on the basis of which you could try to harm the validator/node, but as I can see you think about this too in the AIP itself. Hope it will helps with the connectivity issues between large-distance regions like APAC and LAN/LAS i.e. (but it was more or less fixed with the quorum store AFAIK (based on tests))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants