Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][move-prover] warning about aggregator.limit from prover tests on framework code #15135

Closed
brmataptos opened this issue Oct 31, 2024 · 0 comments · Fixed by #15177
Closed
Assignees
Labels
bug Something isn't working move-prover stale-exempt Prevents issues from being automatically marked and closed as stale

Comments

@brmataptos
Copy link
Contributor

🐛 Bug

I'm noticing a warning (in main) when running a bunch of tests which perhaps noone looks at the output of:

warning: cannot select field of intrinsic struct
   ┌─ /Users/brm/code/aptos-core/aptos-move/framework/aptos-framework/sources/aggregator/aggregator.move:34:9
   │
34 │         aggregator.limit
   │         ^^^^^^^^^^^^^^^^

Based on the error message this is happening in move-prover code. The struct aggregator is defined locally in that code, so I'm not sure we're recognizing it as a field of an intrinsic struct.

This is reproducible by running:

cargo test -p aptos-framework -- move_framework_prover_tests

@rahxephon89 mentions that:

Aggregator has an intrinsic implementation so public fun limit(aggregator: &Aggregator): u128 should be implemented as intrinsic as well. But since aggregator (V1) is not being actively used, fixing this does not have high priority

If this is a valid warning, we should fix the framework code. If not, we should fix the prover/compiler code that is showing a warning about it.

@brmataptos brmataptos added bug Something isn't working move-prover labels Oct 31, 2024
@rahxephon89 rahxephon89 self-assigned this Oct 31, 2024
@brmataptos brmataptos added the stale-exempt Prevents issues from being automatically marked and closed as stale label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working move-prover stale-exempt Prevents issues from being automatically marked and closed as stale
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants