Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Framework][Key rotation] Add OriginatingAddress followup reconciliation function for key rotations without a proof challenge #13517

Open
2 tasks done
alnoki opened this issue Jun 1, 2024 · 0 comments · May be fixed by #14309
Labels
enhancement New feature or request stale-exempt Prevents issues from being automatically marked and closed as stale

Comments

@alnoki
Copy link
Contributor

alnoki commented Jun 1, 2024

Per discussion with @davidiw cc @gedigi @hariria @xbtmatt, addressed in #14309 and documented in aptos-foundation/AIPs#487

Currently, rotate_authentication_key_call does not update the OriginatingAddress table after a successful key rotation without a RotationProofChallenge.

  • Add a public entry reconciliation function, for example of the form account::ensure_originating_address_for_account, which can be called after a successful key rotation via rotate_authentication_key_call.
  • Optionally consider making the function private, via VM-level check that automatically calls the function for every transaction from an account.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale-exempt Prevents issues from being automatically marked and closed as stale
Projects
None yet
2 participants