Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added color for dark theme in navbar to be visible properly #1239

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added color for dark theme in navbar to be visible properly #1239

wants to merge 1 commit into from
+6 −58

Conversation

Utsavladia
Copy link
Contributor

Title and Issue number

Added color for dark theme in navbar to be visible properly #1226

Title :

Issue No. : #1226

Code Stack : css

Close #1226

Video (mandatory)

image

Checklist:

  • I have mentioned the issue number in my Pull Request.
  • I have commented my code, particularly in hard-to-understand areas
  • I have created a helpful and easy to understand README.md
  • I have gone through the contributing.md file before contributing

Additional context (Mandatory )

Are you contributing under any Open-source programme?

  • I'm a GSSOC'24 contributor
  • I'm a SSOC'24 contributor

@github-actions GitHub Actions
Copy link
Contributor

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@netlify Netlify
Copy link

netlify bot commented Aug 10, 2024 •
edited
Loading

✅ Deploy Preview for cute-quokka-b093d8 ready!

Name Link
🔨 Latest commit 3449230
🔍 Latest deploy log https://app.netlify.com/sites/cute-quokka-b093d8/deploys/66b716a7d863b700087e749b
😎 Deploy Preview https://deploy-preview-1239--cute-quokka-b093d8.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Utsavladia
Copy link
Contributor Author

@apu52

Kindly mrege this PR before GSSOC ends 😌

apu52
apu52 requested changes Aug 10, 2024
View reviewed changes
assets/css/style.css
@@ -171,60 +172,6 @@ footer {

color: #cacdd2;
}
/* Newsletter Section Styles */
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why u have deleted the newsletter commits ???
For this changes the newsletter can't be seen in the website home page ...please try to fix this ASAP , otherwise I can't merge your PR .....all the other changes are good

@apu52 apu52 added the help wanted Extra attention is needed label Aug 10, 2024
@Utsavladia
Copy link
Contributor Author

@apu52 may be because of the conflict i deleted it and it was in commented form...

@apu52
Copy link
Owner

apu52 commented Aug 10, 2024

@apu52 may be because of the conflict i deleted it and it was in commented form...

sorry , but I can't merge this PR & also the GSSOC project period is over . Thanks a lot for your valuable contributions.

@Utsavladia
Copy link
Contributor Author

@apu52 may be because of the conflict i deleted it and it was in commented form...

sorry , but I can't merge this PR & also the GSSOC project period is over . Thanks a lot for your valuable contributions.

No issues .. thankyou

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apu52 apu52 apu52 requested changes

Assignees

@Utsavladia Utsavladia

Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Light mode colors are not proper to look properly
2 participants
@Utsavladia @apu52