Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFDiffusion scaffold benchmark #4

Open
JoshuaMeyers opened this issue Jun 12, 2024 · 1 comment
Open

RFDiffusion scaffold benchmark #4

JoshuaMeyers opened this issue Jun 12, 2024 · 1 comment

Comments

@JoshuaMeyers
Copy link

Hey Guys, Cool work its a really nice read. Just a quick comment that I believe the motif scaffolding benchmark as you have implemented does not match the RFDiffusion motifs exactly. The three cases which have small, medium and large scaffolds (6exz, 6e6r, 5trv) are minorly different in the RFDiffusion outputs when compared with your PDB file specifications. This is likely because RFDiffusion seem to index these files differently... I thought I'd flag it in any case.

For example if you download the output sequences from RFDiffusion paper (https://figshare.com/s/439fdd59488215753bc3), and look at the file Motif_scaffolding_benchmark.fasta. You will see that for 6exz the fixed motif is HLE...FMLA while in your file it is LET...MLAE (i.e. offset by one). This is similarly true of the other two cases I mention.

Let me know if you disagree, we hit this minor gotcha a few weeks ago.

@yeqinglin
Copy link
Collaborator

Hi @JoshuaMeyers Thank you very much for pointing this out. We follow the specification from the RFDiffusion paper for this motif scaffolding benchmark, and the fixed motif might be minorly different because of reindexing. We would double check with our motif files again. However, we believe that this should not affect our performance comparisons since we evaluate both RFDiffusion and Genie 2 using the same set of motif files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants