Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation of ignore-policy #3486

Closed
YuriGal opened this issue Jan 26, 2023 · 6 comments · Fixed by #5402
Closed

Improve documentation of ignore-policy #3486

YuriGal opened this issue Jan 26, 2023 · 6 comments · Fixed by #5402
Assignees
Labels
kind/documentation Categorizes issue or PR as related to documentation.

Comments

@YuriGal
Copy link

YuriGal commented Jan 26, 2023

I am trying to create an exception for AVD-AWS-0088, but can get it in a proper format. Could you please provide an example of ignoring a specific AWS rule? Can it be applied to a specific resource only?

@YuriGal YuriGal added the triage/support Indicates an issue that is a support question. label Jan 26, 2023
@itaysk itaysk added kind/documentation Categorizes issue or PR as related to documentation. and removed triage/support Indicates an issue that is a support question. labels Jan 27, 2023
@itaysk
Copy link
Contributor

itaysk commented Jan 27, 2023

Thanks for the report. I hope the info in this discussion helped you. I'll keep this issue open for improving the docs in that area. at the very least clarify what is input

@itaysk itaysk changed the title Example of S3 exception Improve documentation of ignore-policy Jan 27, 2023
@YuriGal
Copy link
Author

YuriGal commented Jan 27, 2023

It's not really ignore policy - if I am not mistaken that applies to vulnerabilities only. I am looking into misconfiguration and exceptions to rules. Basically something like this but for AWS and CloudFormation.

@itaysk
Copy link
Contributor

itaysk commented Jan 27, 2023

Ignore policy and ignore file works for misconfigurations also, as shown in the other thread

@itaysk itaysk added this to the v0.38.0 milestone Feb 7, 2023
@AnaisUrlichs AnaisUrlichs self-assigned this Feb 9, 2023
@itaysk
Copy link
Contributor

itaysk commented Feb 11, 2023

while we're revisiting this doc, we used to refer to this as "exceptions" to be conftest friendly, but we're no longer. The flag is called ignore-policy, so doc needs refresh accordingly

@itaysk
Copy link
Contributor

itaysk commented Feb 14, 2023

I've started a thread to discuss this doc as part of a bigger picture #3620

@github-actions
Copy link

github-actions bot commented Aug 4, 2023

This issue is stale because it has been labeled with inactivity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and will be auto-closed. label Aug 4, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 25, 2023
@itaysk itaysk reopened this Sep 12, 2023
@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and will be auto-closed. label Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes issue or PR as related to documentation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants